Your thread title question can't really be answered. How long a person should be in therapy will vary individual to individual.

I've been with my current therapist for almost 10 years. For much of that I saw him once a week or so, but for the last couple of years I see him only as needed mainly to just check in, every few months.