I don't know that I have a preference. On one hand "manic depressive" is more descriptive. On the other hand the condition is much more than just mania and depression. And "bipolar" is shorter to say.